Repository navigation
[Tests, CMake] Add dependencies in Mapping/Testing CMakeLists.txt - #6394
Merged
fredroy merged 5 commits intoOct 25, 2026
Merged
Conversation
damienmarchal
added
pr: fix
damienmarchal
changed the title
damienmarchal
force-pushed
the
pr-add-dependencies-mapping
branch
from
October 16, 2026 09:33
4a9e2aa to
43eff52
Compare
Contributor
Author
Thanks. |
Contributor
|
Wasn't the project compiled on the CI ? Does this fix a current compilation error ? |
Contributor
Author
|
This fix a compilation error that I is un-detected on the CI because others CMakeLists.txt are hidding the problem. |
damienmarchal
force-pushed
the
pr-add-dependencies-mapping
branch
from
October 16, 2026 11:29
392c557 to
80c4432
Compare
Fix other issues that pop's up when doing so.
damienmarchal
force-pushed
the
pr-add-dependencies-mapping
branch
from
October 16, 2026 11:30
80c4432 to
c3d3d58
Compare
After inclusion of the header in empty.cpp it appears this header was out of sync with a lot of sofa evolution.
…to pr-add-dependencies-mapping
fredroy
approved these changes
Oct 16, 2026
fredroy
changed the title
fredroy
added
pr: status ready
bakpaul
pushed a commit
to bakpaul/sofa
that referenced
this pull request
Oct 29, 2026
…fa-framework#6394) * Add proper dependencies in Mapping/Testing * Add all headers in empty.cpp to force checking the #include Fix other issues that pop's up when doing so. * Fix all errors in Multi2MappingTestCreation.h After inclusion of the header in empty.cpp it appears this header was out of sync with a lot of sofa evolution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some dependencies seems to be missing resulting in missing includes.
This PR fix a compilation error that I is un-detected on the CI because others CMakeLists.txt are hidding the problem. You notice it if you make your own mapping an want to test it in your plugin.
Here is the problem complete description:
The Mapping.Testing target is only containing .h files and "empty.cpp". This empty.cpp does not include the .h... so compiling Mapping.Testing does not involve at all reading the .h.
Looking at one of these header (eg: MappingTestCreation.h) clearly show that, on that target, the proper dependencies are missing resulting in editors errors hints on the #include<>
The Mapping.Testing target is then used as a dependecy to build other target, the ones which actually implements the tests. These targets hides the problem because they adds in there own CMakeLists.txt the missing dependencies (eg: Sofa.Test and Sofa.SimpleAPI). As Mapping.Testing contains only .h stuff adding the dependencies at that location makes everything compile.
If you build your own target to test a mapping using Mapping.Testing... it will not work unless you add manually on your target the dependencies that should be in Mapping.Testing.
I have added #include in empty.cpp. With this change and without the fix the compilation would fail on the CI. This will allow to detect other missing dependencies in the future as well as plenty of error in Multi2Mapping... which makes me thing that nobody is actually using it.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if